Make error overlay filename configurable (facebook#3028)

* Make error overlay file configurable * Add fallback filename
thongdong7 · Sep 24, 2017 · 8b911f3 · 8b911f3
1 parent 66b1a6f
commit 8b911f3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/packages/react-dev-utils/webpackHotDevClient.js b/packages/react-dev-utils/webpackHotDevClient.js
@@ -33,6 +33,7 @@ ErrorOverlay.startReportingRuntimeErrors({
       module.hot.decline();
     }
   },
+  filename: 'static/js/bundle.js',
 });
 
 if (module.hot && typeof module.hot.dispose === 'function') {

diff --git a/packages/react-error-overlay/src/index.js b/packages/react-error-overlay/src/index.js
@@ -21,6 +21,7 @@ import type { ErrorRecord } from './listenToRuntimeErrors';
 type RuntimeReportingOptions = {|
   onError: () => void,
   launchEditorEndpoint: string,
+  filename?: string,
 |};
 
 let iframe: null | HTMLIFrameElement = null;
@@ -55,7 +56,7 @@ export function startReportingRuntimeErrors(options: RuntimeReportingOptions) {
     } finally {
       handleRuntimeError(errorRecord);
     }
-  });
+  }, options.filename);
 }
 
 function handleRuntimeError(errorRecord) {

diff --git a/packages/react-error-overlay/src/listenToRuntimeErrors.js b/packages/react-error-overlay/src/listenToRuntimeErrors.js
@@ -39,7 +39,10 @@ export type ErrorRecord = {|
   stackFrames: StackFrame[],
 |};
 
-export function listenToRuntimeErrors(crash: ErrorRecord => void) {
+export function listenToRuntimeErrors(
+  crash: ErrorRecord => void,
+  filename: string = '/static/js/bundle.js'
+) {
   function crashWithFrames(error: Error, unhandledRejection = false) {
     getStackFrames(error, unhandledRejection, CONTEXT_SIZE)
       .then(stackFrames => {
@@ -68,7 +71,7 @@ export function listenToRuntimeErrors(crash: ErrorRecord => void) {
       {
         message: data.message,
         stack: data.stack,
-        __unmap_source: '/static/js/bundle.js',
+        __unmap_source: filename,
       },
       false
     );
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,6 +33,7 @@ ErrorOverlay.startReportingRuntimeErrors({ @@
           module.hot.decline();
         }
       },
+      filename: 'static/js/bundle.js',
     });
     if (module.hot && typeof module.hot.dispose === 'function') {
@@ Expand Down @@