Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with poetry 1.5+ #284

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

frenzymadness
Copy link
Collaborator

Poetry 1.5 no longer provides category info in poetry.lock.

Fixes: #280

Cc @abompard

Poetry 1.5 no longer provides category info in poetry.lock.

Fixes: thoth-station#280
@op1st-prow op1st-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2023
@op1st-prow
Copy link

op1st-prow bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: goern
Once this PR has been reviewed and has the lgtm label, please ask for approval from frenzymadness. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frenzymadness frenzymadness merged commit d2f2b2d into thoth-station:master Aug 22, 2023
@isaac-florence
Copy link

This fix will be helpful for us being able to upgrade beyond 1.4.2 - is there a date for the next release of poetry? Thanks!

@frenzymadness
Copy link
Collaborator Author

Sorry for the delay. I had a plan to fix more bugs before the next release but I have no time so I'm going to release a new version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Micropipenv does not work with Poetry 1.5.0+
4 participants