Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for poetry 2.0 #313

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

dbIgel
Copy link
Contributor

@dbIgel dbIgel commented Jan 21, 2025

Related Issues and Dependencies

Fixes #312 by updating the _compute_poetry_hashfunction

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

The new poetry 2.0 lock file hash format

Description

Updated the data to be hashed according to https://github.com/python-poetry/poetry/blob/6f6fd7012983a2e749c6030c1f5f155fd4397058/src/poetry/packages/locker.py#L266-L302 to fix verify of poetry 2.0 hashes.

@frenzymadness
Copy link
Collaborator

Thanks a lot for the PR! I'm going to review it.

@dbIgel
Copy link
Contributor Author

dbIgel commented Jan 21, 2025

Looks like the py37-pip193-toml check is failing but i think it's unrelated and seems to be a general problem as other -pip193-toml runs were successful.

Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found some possible improvements. Also, CI si broken so I'm gonna fix it in #314 and you can then rebase this PR.

micropipenv.py Show resolved Hide resolved
micropipenv.py Outdated Show resolved Hide resolved
micropipenv.py Outdated Show resolved Hide resolved
tests/test_micropipenv.py Outdated Show resolved Hide resolved
@frenzymadness
Copy link
Collaborator

The CI should be fine now. Could you please rebase the PR before I start it?

@dbIgel
Copy link
Contributor Author

dbIgel commented Jan 21, 2025

@frenzymadness the branch is rebased and passes the tests

Copy link
Collaborator

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and the old and new tests are passing. Good job! I'm going to merge this and do a new release immediately.

@frenzymadness frenzymadness merged commit a63befe into thoth-station:master Jan 23, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with poetry 2.0
2 participants