-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for poetry 2.0 #313
Conversation
Thanks a lot for the PR! I'm going to review it. |
Looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found some possible improvements. Also, CI si broken so I'm gonna fix it in #314 and you can then rebase this PR.
The CI should be fine now. Could you please rebase the PR before I start it? |
@frenzymadness the branch is rebased and passes the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and the old and new tests are passing. Good job! I'm going to merge this and do a new release immediately.
Related Issues and Dependencies
Fixes #312 by updating the
_compute_poetry_hash
functionThis introduces a breaking change
This Pull Request implements
The new poetry 2.0 lock file hash format
Description
Updated the data to be hashed according to https://github.com/python-poetry/poetry/blob/6f6fd7012983a2e749c6030c1f5f155fd4397058/src/poetry/packages/locker.py#L266-L302 to fix
verify
of poetry 2.0 hashes.