Update docs to require full namespace #1669
Conversation
|
Hey not sure why this is failing. Am I able to resubmit the failing test? |
The tests are failing on main currently, this is not related to your changes. We're working on fixing it on another PR. And thanks for your submission, I hope we can review and approve soon! |
Thank you Sarah. Looks like all the tests are passing now 👍 . |
|
Hi @sarahraqueld I noticed this is still open. Can we re-execute the checks? I don't believe I can on my end. |
|
Thank you, @johnpitchko. Could you rebase against |
FactoryBot throws an error when defining factories that refer to classes within modules in non-Rails applications. FactoryBot will work, but the class used by the factory must be explicitly stated in the full namespace.
johnpitchko
force-pushed
the
update-docs-for-specifying-namespace
branch
from
fbf0c92
to
6ea3d55
Compare
|
Thank you @smaboshe I rebased as you said, but it seems that the Ruby 3.0 / Rails 6.1 build task is stuck in a loop of |
|
Thanks for the rebase. Not sure why that particular build task is failing. We'll take a look. |
|
Hello, I noticed this is still failing and I'm unable to retrigger the build. Can someone investigate or re-trigger please? Thank you. |
FactoryBot throws an error when defining factories that refer to classes within modules in non-Rails applications. FactoryBot will work, but the class used by the factory must be explicitly stated in the full namespace.
Address #1459