Ensure rails 7.2 compatibility #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of `sqlite3` don't compile on recent gcc versions. Additionally, rails < 7.2 currently doesn't work with `sqlite3 ~> 2.0`
In order to use parts of active_support, active_support itself must be required first. https://guides.rubyonrails.org/active_support_core_extensions.html#cherry-picking-a-definition Fixes thoughtbot#1685
Earlopain
force-pushed
the
rails-7.2-compat
branch
from
4e54390
to
d12b7af
Compare
sandbergja
added a commit
to pulibrary/approvals
that referenced
this pull request
Aug 13, 2024
Adds `require "active_support"` to address thoughtbot/factory_bot#1686
christinach
pushed a commit
to pulibrary/approvals
that referenced
this pull request
Aug 13, 2024
Adds `require "active_support"` to address thoughtbot/factory_bot#1686
aramprice
added a commit
to cloudfoundry/bosh
that referenced
this pull request
Aug 14, 2024
Currently `factory_bot` uses `active_support` but does not folow the recommendation to require `active_support` before require'ing specific internals. This is blocking updates to `active_support`. A PR (thoughtbot/factory_bot#1686) exists to address this in `factory_bot`. Once it is released this commit should be reverted.
|
@sarahraqueld @smaboshe could you please review and merge if the changes look good? |
neilvcarvalho
approved these changes
Aug 22, 2024
spec/acceptance/enum_traits_spec.rb
Outdated
| @@ -1,9 +1,17 @@ | |||
| describe "enum traits" do | |||
| def define_model_with_enum(class_name, field, values) | |||
| define_model(class_name, status: :integer) do | |||
| if ActiveRecord::VERSION::STRING >= "7.2" | |||
There was a problem hiding this comment.
Suggested change
| if ActiveRecord::VERSION::STRING >= "7.2" | |
| if ActiveRecord::VERSION::STRING >= "7.0" |
While the old syntax was removed on Rails 7.2, the new one was introduced on 7.0. By referencing the version when it was added we can more easily remove the old syntax when we drop support for Rails < 7.0.
(Rails 6.1 will stop receiving security updates in a month or so, by the way)
There was a problem hiding this comment.
Oh, it was just deprecated, not removed. I thought it was deprecated when the new syntax landed.
There was a problem hiding this comment.
Makes sense, thanks. I applied your suggestion.
> DEPRECATION WARNING: Defining enums with keyword arguments is deprecated and will be removed
in Rails 8.0. Positional arguments should be used instead:
>
> enum :status, {:queued=>0, :started=>1, :finished=>2}
The modern syntax was already introduced in 7.0
Earlopain
force-pushed
the
rails-7.2-compat
branch
from
d12b7af
to
192d5f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1685
This whole thing basically boils down to adding
require "active_support".Additionally, I did the following:
sqlite3fail to compile with gcc 14sqlite3to~> 1.4. Rails 7.1 and lower don't accept 2.0