Fix enums with hashes #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because if you are using a hash instead of a list, you probably should not be using integers as values.
| @@ -126,7 +126,7 @@ def self.statuses; end | |||
| end | |||
|
|
|||
| it "rejects a record where the attribute is not defined as an enum" do | |||
| message = %{Expected #{record_with_hash_values.class} to define :record_with_hash_values as an enum with {:active=>5, :archived=>10} and store the value in a column with an integer type} | |||
| message = %{Expected #{record_with_hash_values.class} to define :record_with_hash_values as an enum with {:active=>5, :archived=>10}} | |||
|
Any response about this PR? |
|
@mcmire any update on this? |
|
This is good, but in order to complete this PR, we need to add a test to confirm that when you have a column that isn't an integer but a string, the matcher won't fail. Do you think you could add that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because if you are using a hash instead of a list, you probably should not be using integers as values.
Fixes issue #912