-
-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #913 for Serialize Matcher error undefined method `cast_type' in Rails 5 #965
Conversation
…_type' in Rails 5 This patch is based on the discussed held in issue thoughtbot#913, and a solution that I've proposed and others have confirmed as good to go 👏. Ref: thoughtbot#913 (comment)
18fe26f
to
91c1d6a
Compare
Thank you @bsodmike. I'm still here... I just haven't had a whole lot of time lately. But I will get to this. |
@mcmire thanks - there seems to be an issue with CI. ta. |
I think it's because this PR does not differ between Rails 5 and 4 like the proposed patch in your comment. What do you think? |
Also it doesn't seem like CI got very far?
This spec was broken locally if I set the version of Rails to |
Usually when rake quits early like that and doesn't show any output it means that some file failed to load. Locally if you run, for instance, |
I ran the tests for this PR locally and this is the error it's failing on
This commit on the If you look at the tests results for the Hopefully this help in moving along the Rails 5 support. |
This patch is based on the discussed held in issue #913, and a solution
that I've proposed and others have confirmed as good to go 👏.
Oh, it also fixes spec breakage (for the existing spec).
Ref: #913 (comment)