Constant parameters values changes #166
Comments
philippkraft
pushed a commit
to philippkraft/spotpy
that referenced
this issue
Sep 3, 2018
philippkraft
pushed a commit
to philippkraft/spotpy
that referenced
this issue
Sep 3, 2018
philippkraft
pushed a commit
to philippkraft/spotpy
that referenced
this issue
Sep 5, 2018
… and build test cases
philippkraft
pushed a commit
to philippkraft/spotpy
that referenced
this issue
Sep 5, 2018
…e constants in sceua and developed a number of tests to ensure the constants stays constant in all samplers.
Merged
|
I have added a test in #179 to check if a constant stays constant. I get no errors (with a constant value of 0). However, before I wrote the test i fixed the parameters of Constant (#177). @jcblemai: Looks like this has been the cause for your strange results. Sorry, we've been a bit hasty, when we included Constant and had not thought of all consequences. Maybe you can checkout the PR #179 and test again? |
philippkraft
pushed a commit
to philippkraft/spotpy
that referenced
this issue
Sep 5, 2018
…e constants in sceua and developed a number of tests to ensure the constants stays constant in all samplers.
bees4ever
added a commit
to bees4ever/spotpy
that referenced
this issue
Sep 17, 2018
* master: Removed _algorithm.model, since it is not legal to call. Use _algorithm.simulate instead Removed all calls to self.model in non-funct samplers and replaced it with calls to _algorithm.simulate Accept List Parameter only for MC sampler Support for mixed paramter generation reactivated. List are not properly tested for different algos Removed unittests for mixed parameter generation. Drop of support Enable dealing with non class parameters Add missing default tuple Eanble the filtering of Constant Parameters in _algorithm.py Changed order of parameters to ensure test on Python < 3.6 Fixed thouska#175 and thouska#166 with extensive check to preserve the constants in sceua and developed a number of tests to ensure the constants stays constant in all samplers. Fixed thouska#175 and thouska#166 with extensive check to preserve the constants in sceua and developed a number of tests to ensure the constants stays constant in all samplers. Added tests for named parameters for all samplers. Fails for mle, sa and sceua Fixed Constant parameter usage for sceua (thouska#166 and thouska#175) and build test cases Added a mechanism to exclude parameter types from a sampler, especially List parameters from any sampler except mc and list Change default dbformat to ram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I encountered a few error, which I believe comes from the parameters.py file.
The value of a constant parameter:
spotpy.parameter.Constant('lambda', 4)isn't constant when I sample with dream. Namely, the first value for every chain is ok, but then next values are fixed to zero.Another catch of the constant parameters is that you cannot have a value fixed at zero:
spotpy.parameter.Constant('lambda', 0)returns MathError because of the log10 in _round_sig(). Shouldn't the minimum and maximum bounds be fixed for these constant parameters ?I hope these are valid issues. Anyway, thanks a lot for spotpy, it is incredibly valuable to my research.
Have a nice day,
Jo
The text was updated successfully, but these errors were encountered: