Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

likelihoods.py, generalizedLikelihoodFunction, Line 530 - np.mean should be np.exp #245

Closed
jds485 opened this issue May 25, 2020 · 1 comment
Closed

likelihoods.py, generalizedLikelihoodFunction, Line 530 - np.mean should be np.exp #245

jds485 opened this issue May 25, 2020 · 1 comment

Comments

@jds485
Copy link

jds485 commented May 25, 2020

According to the cited paper, Line 530 of likelihoods.py should be
mu_t = np.exp(muh * comparedata)
instead of
mu_t = np.mean(muh * comparedata)
thouska added a commit that referenced this issue May 26, 2020
@thouska
Fix according to #245 in generalized likelihood function
cf73991
@thouska
Copy link
Owner

thouska commented May 26, 2020

Hi @jds485
thank you for double checking this one! Your fix is indeed correct. I uploaded your fix in a new version here on Github and on PyPi (>=1.5.10).

@thouska thouska closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thouska @jds485