Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why a numpy array objectivefunction value is not compared when calling self.status in _algorithm/postprocessing.py module #319

Open
OuyangWenyu opened this issue Mar 26, 2024 · 0 comments

Comments

@OuyangWenyu
Copy link

https://github.com/thouska/spotpy/blame/7e5e3f4f268e45e150ba8407dd6747c2f85c4cc0/src/spotpy/algorithms/_algorithm.py#L87

When I use a new loss function which return a numpy array, I found self.compare was ignored in this part:

def __call__(self, objectivefunction, params, block_print=False): self.rep += 1 if type(objectivefunction) == type([]): # TODO: change to iterable self.compare(objectivefunction[0], params) elif type(objectivefunction) == type(np.array([])): pass else: self.compare(objectivefunction, params)

Then in the console the following words will be printed:

"1 of 100, minimal objective function=1e+308, time remaining: 02:01:04"

So I am wondering why numpy array is not allowed?

I am looking forward your reply. Thanks!

OuyangWenyu added a commit to OuyangWenyu/hydromodel that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant