Best likelihood increasing (positive value) instead of decreasing

[KittelC]

Moved statement checking whether likelihood should be false to be taken into account in likelihood calculation.

I am using SCEUA to calibrate hydrological models and I realised when updating my Spotpy module to 1.14 from 1.13.10 that the objective function was positive and therefore increasing rather than decreasing. I propose to move the "negativelike" statement up in the postprocessing function in _algorithm.py - I am not familiar enough with the code to be sure that this has no other effects, but it would seem logical to not only save the likelihood as a negative value is negativelike is True (which appears to be hardcoded in the sceua algorithm), but also to return it from the function as negative (as far as I can see that is the main change).

[coveralls]

Pull Request Test Coverage Report for Build 649

• 18 of 19 (94.74%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 88.733%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
spotpy/algorithms/abc.py	1	2	50.0%

Totals
Change from base Build 642:	0.03%
Covered Lines:	4875
Relevant Lines:	5494

---

💛 - Coveralls

[thouska]

Hi @KittelC,
thank you very much for your proposed change and for reporting this major bug! I highly appreciate your work!
I included your proposed change, added a view other lines because of some minor subsequent errors and will upload a new spotpy version on pypi (1.4.1) today.
I included also a short tutorial for the use of sceua as the use of the negativelike statement is unfortunately very confusing and changed a couple of times during the development of spotpy.