Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update padds.py #251

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Update padds.py #251

merged 1 commit into from
Sep 1, 2020

Conversation

Jinadelee
Copy link
Contributor

This will ensure new_value within the predefined min and max bounds

This will ensure new_value within the predefined min and max bounds
@coveralls
Copy link

Pull Request Test Coverage Report for Build 842

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 89.941%

Files with Coverage Reduction New Missed Lines %
spotpy/algorithms/rope.py 1 93.58%
spotpy/algorithms/sceua.py 2 88.79%
Totals Coverage Status
Change from base Build 836: -0.07%
Covered Lines: 4131
Relevant Lines: 4593

💛 - Coveralls

@thouska
Copy link
Owner

thouska commented Sep 1, 2020

Hi @Jinadelee,
thanks for the contribution, this was indeed an error. Thx for the fix.
Please note that, you might face other unresolved errors in padds as it is in a early beta testing-phase in spotpy, so it is, different to the other implemented algorithms, currently not ready for production use. However, your valueable contribution brings us closer to the goal of having padds robustly implemented.

@thouska thouska merged commit 72f4eb0 into thouska:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants