Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample a predefined number of generations in SCEUA #252

Merged
merged 6 commits into from
Sep 4, 2020
Merged

Sample a predefined number of generations in SCEUA #252

merged 6 commits into from
Sep 4, 2020

Conversation

lu-kas
Copy link

@lu-kas lu-kas commented Sep 4, 2020

This PR covers two things in the SCEUA algorithm:

  1. It corrects the breakpoint logic, as the breakpoint was written too often.
  2. It adds the possibility to define a number of generation to be computed during sampling.

@coveralls
Copy link

coveralls commented Sep 4, 2020

Pull Request Test Coverage Report for Build 849

  • 10 of 22 (45.45%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.774%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotpy/algorithms/sceua.py 10 22 45.45%
Totals Coverage Status
Change from base Build 843: -0.2%
Covered Lines: 4135
Relevant Lines: 4606

💛 - Coveralls

Slight performance improvement for sceua example
@thouska
Copy link
Owner

thouska commented Sep 4, 2020

Great thank you for contribution, this feature will be available in Spotpy version >1.5.11 on PyPi

@thouska thouska merged commit fcce357 into thouska:master Sep 4, 2020
@lu-kas
Copy link
Author

lu-kas commented Sep 4, 2020

Thanks for your great tool! If issues arise in the context of my contribution, please assign me to them directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants