-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: multiple connections management [draft] #1504
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gareth Kirwan <[email protected]>
Co-authored-by: Gareth Kirwan <[email protected]>
shazbert
added
reconstructing
Based on PR feedback, this is currently being reworked and is not to be merged
nomerge requires dependency
This pull request is dependent on another, so it can't be merged until the dependent one is merged
labels
Mar 15, 2024
This will be broken down and built on top of #1580 to expand websocket connections based of subscription count. |
Closing as not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
nomerge requires dependency
This pull request is dependent on another, so it can't be merged until the dependent one is merged
reconstructing
Based on PR feedback, this is currently being reworked and is not to be merged
stale
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Allows websocket connections to be spawned around subscription count to allow for more subscriptions in total
Opened for people to 👀 ball over.
Requires #1493
Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist