gateio: Add websocket request functions for futures trading (btc and usdt margined) #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 14, 2024 16:13
…larity on purpose. Change connections map to point to candidate to track subscriptions for future dynamic connections holder and drop struct ConnectionDetails.
…rror but websocket frame error or anything really makes the reader routine return and then connection never cycles and the buffer gets filled. * Handle reconnection via an errors.Is check which is simpler and in that scope allow for quick disconnect reconnect without waiting for connection cycle. * Dial now uses code from DialContext but just calls context.Background() * Don't allow reader to return on parse binary response error. Just output error and return a non nil response
…would hang connection reader for eternity.
added 18 commits
November 23, 2024 07:16
… item to nil for systems that do not require rate limiting; add glorious nit
shazbert
added
review me
gloriousCode
requested changes
Dec 31, 2024
exchanges/gateio/gateio_test.go
Outdated
| @@ -3451,7 +3451,7 @@ func TestProcessFuturesOrdersPushData(t *testing.T) { | |||
| incoming string | |||
| status order.Status | |||
| }{ | |||
| {`{"channel":"futures.orders","event":"update","time":1541505434,"time_ms":1541505434123,"result":[{"contract":"BTC_USD","create_time":1628736847,"create_time_ms":1628736847325,"fill_price":40000.4,"finish_as":"","finish_time":1628736848,"finish_time_ms":1628736848321,"iceberg":0,"id":4872460,"is_close":false,"is_liq":false,"is_reduce_only":false,"left":0,"mkfr":-0.00025,"price":40000.4,"refr":0,"refu":0,"size":1,"status":"open","text":"-","tif":"gtc","tkfr":0.0005,"user":"110xxxxx"}]}`, order.Open}, | |||
| {`{"channel":"futures.orders","event":"update","time":1541505434,"time_ms":1541505434123,"result":[{"contract":"BTC_USD","create_time":1628736847,"create_time_ms":1628736847325,"fill_price":40000.4,"finish_as":"","finish_time":1628736848,"finish_time_ms":1628736848321,"iceberg":0,"id":4872460,"is_close":false,"is_liq":false,"is_reduce_only":false,"left":0,"mkfr":-0.00025,"price":40000.4,"refr":0,"refu":0,"size":1,"status":"OPEN","text":"-","tif":"gtc","tkfr":0.0005,"user":"110xxxxx"}]}`, order.Open}, | |||
There was a problem hiding this comment.
caps status doesn't match API docs anywhere. Show me some freshly baked order json and I won't make you change it back 🌈
There was a problem hiding this comment.
Yeah I got no idea from memory will test it out again. 👀
exchanges/gateio/gateio_wrapper.go
Outdated
Comment on lines
2646
to
2663
| resp, err = s.DeriveSubmitResponse(got[0].ID) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| resp.Side, err = order.StringToOrderSide(got[0].Side) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| resp.Status, err = order.StringToOrderStatus(got[0].Status) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| resp.Pair = s.Pair | ||
| resp.Date = got[0].CreateTime.Time() | ||
| resp.ClientOrderID = got[0].Text | ||
| resp.Date = got[0].CreateTimeMs.Time() | ||
| resp.LastUpdated = got[0].UpdateTimeMs.Time() | ||
| return resp, nil |
There was a problem hiding this comment.
Do you really trust your submitted values to match 100% with the actual results for all order types? In the other case you don't
There was a problem hiding this comment.
I also set resp.Date twice here. I am sure that must be for efficiency reasons.
There was a problem hiding this comment.
Hopefully addressed this comment here
added 3 commits
January 2, 2025 15:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Requires dependency #1598
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist