Use pytest instead of deprecated nose #153
Conversation
|
Changed the base to py3, once py3 is stable we can pre-release it |
|
Also, waiting for feedback on Bladrak/docker-thumbor-dev#1 and integrating the new image in this MR before merging it |
|
@peterrus new image is in, looks like there's some dependencies issues |
|
@Bladrak could it be that CircleCI is using the config from It should use this one: https://github.com/thumbor-community/aws/blob/py3/.circleci/config.yml I am not very familiar with CircleCI but from a quick search it looks like it always picks the config from That would be problematic because we only want to use the python3 image on python3 branches. We could install python2 and 3 alongside in a shared image and work something out using virtual env's but this would take a bit more work. Another option would be to drop support for Python2 in tc_aws but you might feel that is a bit premature which I can understand. |
|
@peterrus might be because I changed the branch of the MR afterwards and Circle is messing up |
|
Honestly I'm not keen on supporting py2 anymore, but we'd need a stable py3 version before 😅 |
|
Never mind @Bladrak 😂 I had a small lapse of reason. Just had to merge your upstream It seems I broke one unit test by moving to nose. I will fix that ASAP. |
|
@Bladrak Voila! Some funky dependency resolution going in on with regards to boto but nothing blocking! Tests pass now. Regarding your suggestion edit in the version file: Why do we set it to 4 and not something higher than |
|
Sorry, you're right for the version, maybe 7.0b? |
|
@Bladrak sounds good! Somewhat in sync with Thumbor's versioning |
|
@peterrus looks like we have an issue on the deploy script, maybe related to the image, what do you think? https://app.circleci.com/pipelines/github/thumbor-community/aws/20/workflows/7a946629-23c4-45ff-82db-aa4e98bf4154/jobs/283 |
|
Will fix! Strange that this only manifests itself now as I saw some successful runs a few minutes back. https://app.circleci.com/pipelines/github/thumbor-community/aws/18/workflows/28a3b468-fab3-48f8-addf-d94295ee4e3e/jobs/281 for example |
|
Yeah I think it's because the one I linked is on a branch on the repo and tries to release it, the other one might be on the PR so not trying to release it. |
|
@Bladrak ^ should fix it |
|
@peterrus we're probably missing ssh as well |
|
Yeah ssh should be installed as a dependency of git. Let me know whats up. |
|
The deploy key expired on the repo, I re-generated it and it seems to be fine :) |
|
Awesome! @Bladrak Will this also publish a pip package or is that only done for |
|
I thought so but apparently it didn't. I need to check the circle config |
|
Alright. Let me know if you need any help, happy to do so. Thanks for your quick reactions thusfar! |
|
Released on pypi: https://pypi.org/project/tc-aws/7.0b0/ |
With the intention of letting test pass so we can work on #147. In theory
noseshould work with Python3 but it's a dead project andpytestshould be plug and play in this case (tested it locally, seems fine, and the output is a lot nice imho).@Bladrak If CircleCI is still working and you have merged Bladrak/docker-thumbor-dev#1 we should get passing tests again by merging this into #147
Since #147 is not coming from a fork I have push access to could @amanagr maybe give me access to do so?
Alternatively, if @amanagr is not working on/interested in this project anymore maybe @Bladrak can convert #147 to a branch of this repo to be able to easier manage PR's that work on making tc_aws python3 compatible.
I think this could also just be integrated in to
masteras it should be compatible with python2. It's just that merging only this branch won't fix CI tests, we need Bladrak/docker-thumbor-dev#1 for that as well.