Fix stan

thunder · Jan 16, 2025 · 73bce22 · 73bce22
1 parent c033e7f
commit 73bce22
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 9 deletions.
diff --git a/modules/thunder_gqls/tests/src/Kernel/DataProducer/EntitiesWithTermTest.php b/modules/thunder_gqls/tests/src/Kernel/DataProducer/EntitiesWithTermTest.php
@@ -172,7 +172,7 @@ public function testQueryCacheMetadata(): void {
    * @param array $expectedResult
    *   The expected results.
    *
-   * @covers EntitiesWithTerm::resolve
+   * @covers \Drupal\thunder_gqls\Plugin\GraphQL\DataProducer\EntitiesWithTerm::resolve
    *
    * @dataProvider providerEntityWithTerms
    */

diff --git a/modules/thunder_workflow/src/ThunderWorkflowFormHelper.php b/modules/thunder_workflow/src/ThunderWorkflowFormHelper.php
@@ -12,6 +12,7 @@
 use Drupal\Core\Url;
 use Drupal\content_moderation\ModerationInformationInterface;
 use Drupal\content_moderation\StateTransitionValidationInterface;
+use Drupal\node\Entity\Node;
 use Drupal\node\NodeInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\Request;
@@ -75,7 +76,7 @@ public static function create(ContainerInterface $container): self {
   public function formAlter(array &$form, FormStateInterface $form_state): void {
     /** @var \Drupal\Core\Entity\ContentEntityFormInterface $form_object */
     $form_object = $form_state->getFormObject();
-    /** @var \Drupal\node\NodeInterface $entity */
+    /** @var \Drupal\node\Entity\Node $entity */
     $entity = $form_object->getEntity();
 
     if (!$this->moderationInfo->isModeratedEntity($entity)) {
@@ -164,11 +165,10 @@ public function moveStateToActions(NodeInterface $entity, array $form): array {
    *
    * @param array $form
    *   The form array.
-   * @param \Drupal\node\NodeInterface $entity
+   * @param \Drupal\node\Entity\Node $entity
    *   The node entity.
    */
-  public function displayPublishedinformation(array &$form, NodeInterface $entity): void {
-    /** @var \Drupal\node\Entity\Node $entity */
+  public function displayPublishedinformation(array &$form, Node $entity): void {
     /** @var \Drupal\content_moderation\ContentModerationState $state */
     $state = $this->moderationInfo->getWorkflowForEntity($entity)->getTypePlugin()->getState($entity->moderation_state->value);
 

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,6 +1,7 @@
 parameters:
   customRulesetUsed: true
   reportUnmatchedIgnoredErrors: true
+  treatPhpDocTypesAsCertain: false
   level: 6
   ignoreErrors:
     # new static() is a best practice in Drupal, so we cannot fix that.

diff --git a/tests/src/FunctionalJavascript/Integration/EntityReferenceActionsTest.php b/tests/src/FunctionalJavascript/Integration/EntityReferenceActionsTest.php
@@ -20,7 +20,6 @@ class EntityReferenceActionsTest extends ThunderJavascriptTestBase {
    */
   public function testMediaEditInArticle(): void {
 
-    /** @var \Drupal\node\Entity\Node $node */
     $node = $this->loadNodeByUuid('36b2e2b2-3df0-43eb-a282-d792b0999c07');
     $this->drupalGet($node->toUrl('edit-form'));
 

diff --git a/tests/src/FunctionalJavascript/MediaImageModifyTest.php b/tests/src/FunctionalJavascript/MediaImageModifyTest.php
@@ -80,7 +80,6 @@ public function testRemoveAdd(): void {
     $this->assertSession()
       ->elementNotExists('css', '[data-drupal-selector="edit-field-paragraphs-0-subform-field-image-wrapper"] div.messages--error');
 
-    /** @var \Drupal\media\Entity\Media $image2 */
     $image2 = $this->loadMediaByUuid('a4b2fa51-8340-4982-b792-92e060b71eb9');
     $this->selectMedia('field-paragraphs-0-subform-field-image', [$image2->id()]);
 

diff --git a/tests/src/Traits/ThunderTestTrait.php b/tests/src/Traits/ThunderTestTrait.php
@@ -176,7 +176,7 @@ protected function tearDown(): void {
    * @param string $uuid
    *   The uuid.
    *
-   * @return \Drupal\media\MediaInterface
+   * @return \Drupal\media\Entity\Media
    *   The media entity.
    *
    * @throws \Drupal\Core\Entity\EntityStorageException
@@ -193,7 +193,7 @@ protected function loadMediaByUuid(string $uuid): MediaInterface {
    * @param string $uuid
    *   The uuid.
    *
-   * @return \Drupal\node\NodeInterface
+   * @return \Drupal\node\Entity\Node
    *   The node entity.
    *
    * @throws \Drupal\Core\Entity\EntityStorageException