Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Usage of paragraphs edit all feature #764

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Enable Usage of paragraphs edit all feature #764

merged 6 commits into from
Jan 9, 2024

Conversation

ol0lll
Copy link
Member

@ol0lll ol0lll commented Jan 4, 2024

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-764 January 4, 2024 10:25 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-764 January 4, 2024 10:48 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-764 January 4, 2024 10:59 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-764 January 4, 2024 11:28 Inactive
IT-Cru
IT-Cru approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@IT-Cru IT-Cru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for us with PR of thunder/paragraphs_features PR 77
thunder/paragraphs_features#77

@ol0lll ol0lll merged commit 2bf0b6b into 7.1.x Jan 9, 2024
6 checks passed
@ol0lll ol0lll deleted the fix/enable-usage-of-paragraphs-edit-all-feature branch January 9, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-Cru IT-Cru IT-Cru approved these changes

@chrfritsch chrfritsch chrfritsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ol0lll @chrfritsch @IT-Cru