Issue closed too early.

[dhaavi]

Hey there,

first of all, thanks for this cool action, it helps us a lot!

We just wanted to expand our usage, but only want the issue manager to remove a label, not close the issue.
As this does not work, I wanted to add a 10 year delay as a workaround, but this closed some issues that are considerably younger.

My config: https://github.com/safing/portmaster/blob/54c3105f18e93ce25b3c8fd1bc2cd232b7e77760/.github/workflows/issue-manager.yml

One affected issue: safing/portmaster#75

[dhaavi]

Here is the log output from the affected workflow run:

INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Not clossing issue: #289 as the delay hasn't been reached: 3650 days, 0:00:00
INFO:root:Processing issue: #273
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Not clossing issue: #273 as the delay hasn't been reached: 3650 days, 0:00:00
INFO:root:Processing issue: #250
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Not clossing issue: #250 as the delay hasn't been reached: 3650 days, 0:00:00
INFO:root:Processing issue: #249
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Clossing issue: #249 with message: That was 10 years ago, I think we can close this now.
INFO:root:Processing issue: #166
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Not clossing issue: #166 as the delay hasn't been reached: 3650 days, 0:00:00
INFO:root:Processing issue: #[150](https://github.com/safing/portmaster/runs/5159266561?check_suite_focus=true#step:3:150)
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Not clossing issue: #150 as the delay hasn't been reached: 3650 days, 0:00:00
INFO:root:Processing issue: #99
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Clossing issue: #99 with message: That was 10 years ago, I think we can close this now.
INFO:root:Processing issue: #77
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Not clossing issue: #77 as the delay hasn't been reached: 3650 days, 0:00:00
INFO:root:Processing issue: #75
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Clossing issue: #75 with message: That was 10 years ago, I think we can close this now.
INFO:root:Processing issue: #45
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Clossing issue: #45 with message: That was 10 years ago, I think we can close this now.
INFO:root:Processing issue: #13
INFO:root:Keyword: "waiting for resources" in issue labels
INFO:root:Clossing issue: #13 with message: That was 10 years ago, I think we can close this now.

It clearly says 3650 days, but the last activity on safing/portmaster#75 is clearly younger.

[dhaavi]

Ah, I think I got it now.

This may actually be a duplicate of #14.

[tiangolo]

Hello, the delay is parsed by Pydantic: https://docs.pydantic.dev/latest/concepts/types/#datetime-types

I think in Pydantic v1 it would parse integers up to some value as seconds, and above that value as milliseconds (I think as an effort to handle compatibility with JS milliseconds numbers by default).

I think that's no longer like that in Pydantic v2.

I tried checking your workflow but it seems it no longer uses issue-manager, so I suspect you handled your need already. 🤓