Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

🎨 Refactor tag names prefixed with conda to no prefix #1

Merged
merged 1 commit into from
Mar 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@

## Supported tags and respective `Dockerfile` links

* [`conda-python3.7`, `latest` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/conda-python3.7/Dockerfile)
* [`conda-python3.6` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/conda-python3.6/Dockerfile)
* [`conda-cuda9.1-python3.7` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/conda-cuda9.1-python3.7/Dockerfile)
* [`conda-cuda9.1-python3.6` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/conda-cuda9.1-python3.6/Dockerfile)
* [`conda-python3.6-tensorflow` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/conda-python3.6-tensorflow/Dockerfile)
* [`conda-cuda9.1-python3.6-tensorflow` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/conda-cuda9.1-python3.6-tensorflow/Dockerfile)
* [`python3.7`, `latest` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/python3.7/Dockerfile)
* [`python3.6` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/python3.6/Dockerfile)
* [`cuda9.1-python3.7` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/cuda9.1-python3.7/Dockerfile)
* [`cuda9.1-python3.6` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/cuda9.1-python3.6/Dockerfile)
* [`python3.6-tensorflow` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/python3.6-tensorflow/Dockerfile)
* [`cuda9.1-python3.6-tensorflow` _(Dockerfile)_](https://github.com/tiangolo/python-machine-learning-docker/blob/master/cuda9.1-python3.6-tensorflow/Dockerfile)


# python-machine-learning
Expand Down Expand Up @@ -78,15 +78,15 @@ There are also versions with TensorFlow and CUDA. So, you can run TensorFlow (bu
* You don't need to clone the GitHub repo. You can use this image as a base image for other images, using this in your `Dockerfile`:

```Dockerfile
FROM tiangolo/python-machine-learning:conda-python3.7
FROM tiangolo/python-machine-learning:python3.7

COPY ./main.py /app/main.py
```

or any of the image variants, e.g.:

```Dockerfile
FROM tiangolo/python-machine-learning:conda-cuda9.1-python3.6-tensorflow
FROM tiangolo/python-machine-learning:cuda9.1-python3.6-tensorflow

COPY ./main.py /app/main.py
```
Expand All @@ -98,7 +98,7 @@ You can override that behavior and run your own program creating a file at `/sta
For example:

```Dockerfile
FROM tiangolo/python-machine-learning:conda-python3.7
FROM tiangolo/python-machine-learning:python3.7

COPY ./start.sh /start.sh
RUN chmod +x /start.sh
Expand Down
26 changes: 13 additions & 13 deletions docker-compose.build.stage01.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
version: '3'
services:
latest:
build: ./conda-python3.7
build: ./python3.7
image: tiangolo/python-machine-learning:latest
conda-python3.7:
build: ./conda-python3.7
image: tiangolo/python-machine-learning:conda-python3.7
conda-python3.6:
build: ./conda-python3.6
image: tiangolo/python-machine-learning:conda-python3.6
conda-cuda9.1-python3.7:
build: ./conda-cuda9.1-python3.7
image: tiangolo/python-machine-learning:conda-cuda9.1-python3.7
conda-cuda9.1-python3.6:
build: ./conda-cuda9.1-python3.6
image: tiangolo/python-machine-learning:conda-cuda9.1-python3.6
python3.7:
build: ./python3.7
image: tiangolo/python-machine-learning:python3.7
python3.6:
build: ./python3.6
image: tiangolo/python-machine-learning:python3.6
cuda9.1-python3.7:
build: ./cuda9.1-python3.7
image: tiangolo/python-machine-learning:cuda9.1-python3.7
cuda9.1-python3.6:
build: ./cuda9.1-python3.6
image: tiangolo/python-machine-learning:cuda9.1-python3.6
12 changes: 6 additions & 6 deletions docker-compose.build.stage02.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
version: '3'
services:
conda-python3.6-tensorflow:
build: ./conda-python3.6-tensorflow
image: tiangolo/python-machine-learning:conda-python3.6-tensorflow
conda-cuda9.1-python3.6-tensorflow:
build: ./conda-cuda9.1-python3.6-tensorflow
image: tiangolo/python-machine-learning:conda-cuda9.1-python3.6-tensorflow
python3.6-tensorflow:
build: ./python3.6-tensorflow
image: tiangolo/python-machine-learning:python3.6-tensorflow
cuda9.1-python3.6-tensorflow:
build: ./cuda9.1-python3.6-tensorflow
image: tiangolo/python-machine-learning:cuda9.1-python3.6-tensorflow
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions tests/test_cpu/test_conda.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ def verify_container(logs, python_version):
@pytest.mark.parametrize(
"image,python_version",
[
("tiangolo/python-machine-learning:conda-python3.6", "3.6"),
("tiangolo/python-machine-learning:conda-python3.7", "3.7"),
("tiangolo/python-machine-learning:python3.6", "3.6"),
("tiangolo/python-machine-learning:python3.7", "3.7"),
],
)
def test_defaults(image, python_version):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cpu/test_conda_tensorflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def verify_container(logs, python_version):

@pytest.mark.parametrize(
"image,python_version",
[("tiangolo/python-machine-learning:conda-python3.6-tensorflow", "3.6")],
[("tiangolo/python-machine-learning:python3.6-tensorflow", "3.6")],
)
def test_defaults(image, python_version):
remove_previous_container(client)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_cuda/test_conda_cuda.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ def verify_container(logs, python_version):
@pytest.mark.parametrize(
"image,python_version",
[
("tiangolo/python-machine-learning:conda-cuda9.1-python3.6", "3.6"),
("tiangolo/python-machine-learning:conda-cuda9.1-python3.7", "3.7"),
("tiangolo/python-machine-learning:cuda9.1-python3.6", "3.6"),
("tiangolo/python-machine-learning:cuda9.1-python3.7", "3.7"),
],
)
def test_defaults(image, python_version):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cuda/test_conda_cuda_tensorflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def verify_container(logs, python_version):

@pytest.mark.parametrize(
"image,python_version",
[("tiangolo/python-machine-learning:conda-cuda9.1-python3.6-tensorflow", "3.6")],
[("tiangolo/python-machine-learning:cuda9.1-python3.6-tensorflow", "3.6")],
)
def test_defaults(image, python_version):
remove_previous_container(client)
Expand Down