-
-
Notifications
You must be signed in to change notification settings - Fork 608
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
📝 Add docs for custom /app/nginx.conf
- Loading branch information
Showing
1 changed file
with
24 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2adde9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for maintaining this repo.
Please make a new tag for updated Docker images, or make use of feature flags (like environment variables) so the backward compatibility will not be broken.
For example, this great feature break down some of our CI/CD pipelines, since we manually override the nginx.conf with file named /app/nginx.conf, while using tiangolo/uwsgi-nginx-flask:python3.6-alpine3.7 image for more than a year.
TNX
2adde9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Bezbran , thanks for your patience. There are now Docker image tags based on the date. Those are never modified later, check the note here: https://github.com/tiangolo/uwsgi-nginx-flask-docker#supported-tags-and-respective-dockerfile-links
2adde9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Thanks