Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellPkg: Changes to print Type17 in Smbiosview #5620

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

shenbagadevir
Copy link
Contributor

Add changes to print PMIC and RCD details of Smbios Type17 in Shell smbiosview command.

Cc: Gaoliming [email protected]
Cc: Sainadh N [email protected]
Cc: Sundaresan S [email protected]
Cc: Srinivasan M [email protected]
Cc: Ramesh R [email protected]
Cc: Karthika R [email protected]

Reviewed-by: Giri Mudusuru [email protected]

@shenbagadevir
Copy link
Contributor Author

Hi @GiriM123 ,

Facing build errors
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘Pmic0ManufacturerID’; did you mean ‘ModuleManufacturerID’?
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘Pmic0RevisionNumber’
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘RcdManufacturerID’; did you mean ‘Manufacturer’?
ERROR - Compiler #error from /__w/1/s/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c ‘SMBIOS_TABLE_TYPE17’ has no member named ‘RcdRevisionNumber’
ERROR - Compiler #7000 from : Failed to execute command
ERROR - EDK2 #2 from : Failed to build module
CRITICAL - Build failed

But all these members are defined in SMBIOS_TABLE_TYPE17 structure in SmBios.h of MdePkg and created merge request for the same.
Please help to review this and merge.

Cc: @lgao4
Cc: @sainadhnagolu

Thanks,
Shenba

Copy link

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added stale Due to lack of updates, this item is pending deletion. and removed stale Due to lack of updates, this item is pending deletion. labels Jul 15, 2024
Add changes to print PMIC and RCD details of Smbios Type17 in Shell
smbiosview command.

Cc: Gaoliming <[email protected]>
Cc: Sainadh N <[email protected]>
Cc: Sundaresan S <[email protected]>
Cc: Srinivasan M <[email protected]>
Cc: Ramesh R <[email protected]>
Cc: Karthika R <[email protected]>

Signed-off-by: Shenbagadevi R <[email protected]>
Reviewed-by: Giri Mudusuru <[email protected]>
@shenbagadevir
Copy link
Contributor Author

shenbagadevir commented Jul 22, 2024

Hi @GiriM123 / @lgao4,
Please help to review this pull request.

Thanks

@lgao4 lgao4 added the push Auto push patch series in PR if all checks pass label Jul 23, 2024
@mergify mergify bot merged commit 46eb0ca into tianocore:master Jul 23, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants