EmulatorPkg: spurious failure in WriteBlocks on X64 #6487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WinNtBlockIoWriteBlocks can spuriously fail on X64. This occurs because &BytesWritten is a
UINTN*
(i.e.UINT64*
) but is cast toLPDWORD
(i.e.UINT32*
). Only the low 32 bits are initialized by WriteFile, so the high 32 bits are uninitialized. This means we will spuriously fail theBytesWritten != BufferSize
test.This doesn't occur on X86-32 since UINTN is the same as DWORD in that case.
Fix is to declare BytesWritten as DWORD to match the type expected by WriteFile. This also makes the cast unnecessary.
How This Was Tested
Integration Instructions
N/A