UsbBusDxe: Add quirk for Framework Ethernet Expansion Card #6526
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Framework Ethernet Expansion card uses an Realtek 8156 chip. It has a device descriptor with three configurations: - Vendor Specific - CDC NCM - CDC ECM The default configuration cannot be used by drivers available in EDK2, so we must change it. FreeBSD used to have the same quirk before they implemented a custom driver for Realtek adapters: freebsd/freebsd-src@6ea4d95 Realtek provides a proprietary UEFI driver, but with this change, the open source EDK2 driver also works. Selecting configuration 1 results in > drivers 8A 00000001 D - - 1 - USB NCM Driver UsbCdcNcm Selecting configuration 2 results in > drivers 89 00000001 D - - 1 - USB ECM Driver UsbCdcEcm Both of them can work with iPXE/netboot.xyz Tested in QEMU/OVMF by passing the USB device through. > sudo qemu-system-x86_64 -bios Build/OvmfX64/DEBUG_GCC5/FV/OVMF.fd -m 4G \ -device qemu-xhci,id=xhci -device usb-host,bus=xhci.0,vendorid=0x0bda,productid=0x8156 \ -nic none \ -cdrom netboot.xyz.iso Signed-off-by: Daniel Schaefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Framework Ethernet Expansion card uses an Realtek 8156 chip. It has a device descriptor with three configurations:
The default configuration cannot be used by drivers available in EDK2, so we must change it.
FreeBSD used to have the same quirk before they implemented a custom driver for Realtek adapters:
freebsd/freebsd-src@6ea4d95
Realtek provides a proprietary UEFI driver, but with this change, the open source EDK2 driver also works.
How This Was Tested
Selecting configuration 1 results in
Both of them can work with iPXE/netboot.xyz
Tested in QEMU/OVMF by passing the USB device through.