Add workflow to generate API client code in tidalapi module #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michpohl
force-pushed
the
michael/Add-workflow-to-re-generate-TidalApi-module-code
branch
2 times, most recently
from
dfa0cc9 to
ad34e63
Compare
e-kononenko
previously approved these changes
Oct 29, 2024
This workflow: 1. downloads the latest available release from our openapi fork 2. Runs the generator script to download and merge the schemas and feed them to the generator 3. If it finds changes creates a PR with them
If running the script locally, you might either manually place the jar there, or change this entry to point to the location of your choice.
The tidal-kotlin one was only for development and doesn't exist in the fork anymore
michpohl
force-pushed
the
michael/Add-workflow-to-re-generate-TidalApi-module-code
branch
from
ad34e63 to
6c0986f
Compare
Please do! |
e-kononenko
previously approved these changes
Oct 29, 2024
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
The other workflows in tidal-sdk-android are already using checkout@v4. It shouldn't be a problem, just fyi for consistency.
There was a problem hiding this comment.
no you are right. This should be updated. Thanks!
ziad-halabi9
approved these changes
Oct 30, 2024
michpohl
deleted the
michael/Add-workflow-to-re-generate-TidalApi-module-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the workflow to re-generate the API code in the
:tidalapimodule.The workflow is (for now) manually triggered. A pull request created by it looks like this.
This workflow: