-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generated catalogue models #19
Conversation
catalog/src/main/kotlin/org/openapitools/client/apis/AlbumJSONAPI.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
Outdated
Show resolved
Hide resolved
catalog/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
Outdated
Show resolved
Hide resolved
Rename to catalogue please :) We follow the same naming as the corresponding API domain: https://developer.tidal.com/reference/web-api?spec=catalogue-v2&ref=get-albums-v2 |
Will do! This info came after the modules had been created and I will fix the naming in a separate PR for both iOS and Android! Good? |
731b0d2
to
f3fff09
Compare
Ok, so I'm not merging this for now. The reason: As you can see above, lint points this out - and initially I wanted to just override this, but since no one uses this yet, I will first do another look at what I can do about it. |
f3fff09
to
9a90659
Compare
@CanYumusak I found issues with the generator and therefore opted to only push the models for now (as is requested) |
9a90659
to
e13e576
Compare
e13e576
to
3e30d61
Compare
3e30d61
to
5df8ea7
Compare
This adds generated catalogue code made using openapi-generator-clifrom our catalog API endpoint definitions.
Only the generated models have been added so far. Generated helper class have issues with maitaining compatibility with Android SDKs <26, so I left them out for now.
This is a temporary version intended for prototyping. It will be subject to change.
The generated code has a few small issues, but if you're looking to use just the types, you'll be fine.
This also adds
catalogue-openapi.json
, our current state of the ASPI definition,and
openapi-config.yml
, specifying the generator-specific args used for generation.This was the actual command used, from SDK root:
This will also not be released in a public package yet - some improvements need to be made for a first "official" release.
If you have trouble creating a local release to work with this hit me up, and I'll show you how.