Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround K8s bug that prevents AWS EKS IAM for Service Accounts #40

Merged
merged 5 commits into from
Oct 11, 2019

Conversation

derrickburns
Copy link
Contributor

@derrickburns derrickburns commented Oct 11, 2019

See kubernetes-sigs/external-dns#1185 (comment)

Also, split arguments to script to get secrets from AWS Secrets Manager.

The movement of the SecurityContext is because there are 2 different Security Context objects. We need access to the outer one to workaround the bug.

@derrickburns derrickburns requested a review from pazaan October 11, 2019 06:05
Copy link
Contributor

@pazaan pazaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@pazaan pazaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@derrickburns derrickburns merged commit 33f91fe into develop Oct 11, 2019
@derrickburns derrickburns deleted the iam branch October 11, 2019 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants