Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out signature pads (UPLOAD-1393) #1660

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Conversation

gniezen
Copy link
Member

@gniezen gniezen commented Oct 3, 2024

Addresses UPLOAD-1393.

vojtech-cerveny
vojtech-cerveny previously approved these changes Oct 3, 2024
Copy link
Contributor

@vojtech-cerveny vojtech-cerveny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda weird that serialNumber can be TOPAZBSB 🤦 but it is what it is.

LGTM 🚀

@gniezen
Copy link
Member Author

gniezen commented Oct 3, 2024

@vojtech-cerveny I know, right? Why put the name of the device in the serial number field, not the name field? 🙃

Copy link
Contributor

@vojtech-cerveny vojtech-cerveny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM 🚀

@gniezen gniezen merged commit 096766d into master Oct 31, 2024
4 checks passed
@gniezen gniezen deleted the filter-signature-pads branch October 31, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants