-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combine fails to combine a list of characters with NA [with pull request: #2209] #2203
Comments
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Oct 27, 2016
Combine should work with NA and characters
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Oct 27, 2016
This commit fixes tidyverse#2203 by adding compatibility to the character Collecter so it accepts logical missing values and replaces them with NA_character_ as expected.
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Oct 27, 2016
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Nov 7, 2016
This commit tests if dplyr::combine accepts NA in all atomic classes: - logical - integer - factor - real - character - POSIXct - Date - complex
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Nov 7, 2016
This commit fixes tidyverse#2203 by allowing the collecters to accept logical missing values, replacing them with the specific NA value for each Rtype as expected.
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Nov 7, 2016
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Nov 13, 2016
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Nov 13, 2016
…n rules This commit fixes issue tidyverse#2203, allowing combine to deal with missing values. Additionally it restricts coercion rules, in particular coercing logical to integer or double is not allowed anymore. Other coercion cases will give warnings, if information may be lost in the conversion, for instance when coercing integers with classes, such as difftime.
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Nov 13, 2016
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Nov 13, 2016
…n rules This commit fixes issue tidyverse#2203, allowing combine to deal with missing values. Additionally it restricts coercion rules, in particular coercing logical to integer or double is not allowed anymore. Other coercion cases will give warnings, if information may be lost in the conversion, for instance when coercing integers with classes, such as difftime.
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Jan 27, 2017
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Jan 27, 2017
…n rules This commit fixes issue tidyverse#2203, allowing combine to deal with missing values. Additionally it restricts coercion rules, in particular coercing logical to integer or double is not allowed anymore. Other coercion cases will give warnings, if information may be lost in the conversion, for instance when coercing integers with classes, such as difftime.
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Jan 30, 2017
zeehio
added a commit
to zeehio/dplyr
that referenced
this issue
Jan 30, 2017
…n rules This commit fixes issue tidyverse#2203, allowing combine to deal with missing values. Additionally it restricts coercion rules, in particular coercing logical to integer or double is not allowed anymore. Other coercion cases will give warnings, if information may be lost in the conversion, for instance when coercing integers with classes, such as difftime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
Thanks to everyone working on tibble, dplyr, tidyr... In general the tidyverse packages make a lot of people very happy to use R.
I have found a rather simple case where
dplyr::combine
fails, and the do.call rbind equivalent works as expected. I have tested this on the latest released dplyr and the current master (b205d1f) versions, both showing the same error. I found this error trying to unnest a data frame using tidyr, but my C++ skills and dplyr knowledge are not good enough to fix it.This issue affects
unnest
in tidyr:Any help will be appreciated
The text was updated successfully, but these errors were encountered: