Improve docs for geom_contour as discussed in issue #4324 #4325
Conversation
|
The failures I'm seeing in the tests don't seem to be related to the changes I made. I did add an example to |
|
Yes, we can ignore those failures; they are due to a slight change introduced in the recent version of sf (c.f. #4311). Sorry for the confusion. |
* Remove leading space in document Remove leading space in the document of position_jitterdodge() * Document Co-authored-by: GitHub Actions <[email protected]>
brew cask is now deprecated in favor of the `--cask` argument
There was a problem hiding this comment.
Looks good!
@clauswilke
I think this is fine to merge. This is only a Suggest dependency and is just for documentation so we can remove this easily if we found any problem in future. Any concerns?
|
No concerns about the external dependency. I haven't carefully checked the various CI failures. |
|
Thanks, for R-CMD-check, failures of windows-latest and ubuntu-16.04 is due to visual cases, which #4311 should fix. macOS-latest errors on setting up XQuartz, I guess this is a temporary one. For test-coverage, it fails at the same XQuartz setup. None seems caused by this pull request. |
* Update vdiffr cases * Use `brew install` instead of `brew cask install`
|
Thanks for contributing! |
No description provided.