-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full support for ragg #4388
Conversation
…ents in passed in device
While you're at it, I would suggest to add at least the unit |
Yeah — px should at least be supported. I don't think pt has much merit as an output dimension unit? |
Normally my attitude would be "it doesn't cost much to add pt so why not" but I can see that people might get confused about the difference between px and pt so maybe better leave it out. |
Yeah, that is kinda my worry as well |
I've added px support - @clauswilke can you give this a review? |
Fix #4347
This PR does two things: First, it will use ragg as the default device if it is installed when generating png, jpeg, and tiff files. Second, it fixes the issue that has crippled the use of
device = agg_png
in ggsave, in that it explicitly sets the resolution and units to use in the device function that is passed in. While this only works for devices that usesres
andunits
arguments it means that devices that uses the same signature aspng()
will work the same way