-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Using date breaks/minor breaks/labels in time scales. #6282
Conversation
…ses" This reverts commit adcd2cb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the name date_breaks
for this because a date has a fixed position in time whereas the time scale is relative. But for symmetry with the other scales it is probably worth this minor gripe
I also don't think the names are great, but I'm not a big fan of the date break mechanism to begin with. |
This PR aims to fix #4335.
Briefly, it pulls
scale_{x/y}_time()
into thedatetime_scale()
-fold of functions.I'm at a slight 'Chesterton's fence'-risk because I don't know why
scale_{x/y}_time()
was excluded in the first place, but I'll take the risk.