Fixed typo in README. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
jayhesselberth
added a commit
to rnabioco/purrr
that referenced
this pull request
Jan 11, 2025
I confirmed that clang-asan fails on current purrr with a similar error to what we're seeing in valr. This is in purrr-Ex.Rout from [this rhub check](https://github.com/jayhesselberth/purrr/actions/runs/12720310041/job/35461775454). ``` cleancall.c:110:46: runtime error: call to function cb_progress_done through pointer to incorrect function type 'void (*)(void *)' /__w/purrr/purrr/check/purrr.Rcheck/00_pkg_src/purrr/src/map.c:15: note: cb_progress_done defined here #0 0x7fd287f0d48b in call_exits /__w/purrr/purrr/check/purrr.Rcheck/00_pkg_src/purrr/src/cleancall.c:110:46 tidyverse#1 0x7fd28ddf1131 in R_ExecWithCleanup /tmp/R-devel/src/main/context.c:913:5 tidyverse#2 0x7fd287f0cdf2 in r_with_cleanup_context /__w/purrr/purrr/check/purrr.Rcheck/00_pkg_src/purrr/src/cleancall.c:133:14 ``` This simple patch proposed on the R-devel mailing list fixes that clang-asan error ([clang asan run](https://github.com/jayhesselberth/purrr/actions/runs/12718786947/job/35457848128)). Also updated the rhub action because it was useful to debug this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.