Should show_progress() use rlang::is_interactive()?

[DavisVaughan]

readr/R/utils.R

Line 23 in a14f189

interactive() && # an interactive session

I naively tried rlang::with_interactive(value = FALSE, {expression-that-calls-read_tsv()}) and was surprised that I still saw the indexing output from vroom. I guess this is because this sets the rlang specific interactive option, which readr/vroom won't recognize.

This should also be thought about in tandem with vroom_progress()
https://github.com/r-lib/vroom/blob/eaab3e161c2d82b922217e7b19a315f7c939af18/R/vroom.R#L237

I know about the progress argument that I could set directly, but this still feels relevant

[jennybc]

Yeah, I basically think we should always use rlang::is_interactive() for these purposes.