More helpful error when trying to write out data frames with list columns #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jul 8, 2019
R/write.R
Outdated
| format(x, "%Y-%m-%dT%H:%M:%OSZ", tz = "UTC", justify = "none") | ||
| } | ||
|
|
||
| #' @export | ||
| output_column.list <- function(x, name) { | ||
| stop(paste0("Flat files can't store the list column '", name, "'")) |
There was a problem hiding this comment.
I think this should use ` rather than ', and you need a call. = FALSE on the end. Also stop() automatically pastes together it's inputs, you can remove the paste() if you want.
tests/testthat/test-write.R
Outdated
| @@ -163,3 +163,11 @@ test_that("hms NAs are written without padding (#930)", { | |||
| df <- data.frame(x = hms::as.hms(c(NA, 34.234))) | |||
| expect_equal(format_tsv(df), "x\nNA\n00:00:34.234\n") | |||
| }) | |||
|
|
|||
| test_that("More helpful error when trying to write out data frames with list columns (#938)", { | |||
| df <- tibble::tibble(id = seq(11)) | |||
There was a problem hiding this comment.
I'd make this a little simpler: df <- tibble(x = 1, y = list(1))
tests/testthat/test-write.R
Outdated
| df$list <- lapply(X = seq_along(df$id), FUN = rnorm, n = 3) | ||
| filename <- file.path(tempdir(), "test_list.csv") | ||
| on.exit(unlink(filename)) | ||
| expect_error(write_csv(x = df, path = filename), "Flat files can't store the list column '") |
There was a problem hiding this comment.
I'd just do write_csv(df, tempfile()) — you don't need to clean up since this won't read a file.
|
Thanks @hadley, I push some new changes following your suggestions! |
hadley
approved these changes
Jul 8, 2019
|
Thanks @ellessenne |
jimhester
added a commit
that referenced
this pull request
Jan 8, 2021
Because of the way #1009 was implemented it caused a bug when writing data with duplicated column names. It also only preformed the check for `write_delim()`, not for all the writing functions. We now do this in a different way, which again restores the ability to write data with duplicated columns. Fixes #1169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #938:
However, this approach does not work so well when multiple list columns are present:
Is this behaviour acceptable or would it be better to print the names of all unsupported list columns at once?
Alessandro