Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take advantage of some backtrace improvements #433

Closed
jennybc opened this issue Feb 10, 2023 · 3 comments · Fixed by #449
Closed

Take advantage of some backtrace improvements #433

jennybc opened this issue Feb 10, 2023 · 3 comments · Fixed by #449
Labels
upkeep maintenance, infrastructure, and similar

Comments

@jennybc
Copy link
Member

jennybc commented Feb 10, 2023

Details in r-lib/rlang#1557, which would need to be merged and released first.

reprex/R/reprex_document.R

Lines 136 to 141 in 77ec1f6

options(
keep.source = TRUE,
rlang_backtrace_on_error_report = "full",
crayon.enabled = FALSE,
reprex.current_venue = "{venue}"
)

should look more like

rlang::global_entrace()
options(
  keep.source = TRUE,
  rlang_backtrace_on_error_report = "full",
  rlang_backtrace_on_warning_report = "full"
  crayon.enabled = FALSE,
  reprex.current_venue = "{venue}"
)
@jennybc jennybc added the upkeep maintenance, infrastructure, and similar label Feb 10, 2023
@lionel-
Copy link
Member

lionel- commented Feb 16, 2023

This would also close #230.

@jennybc
Copy link
Member Author

jennybc commented Mar 8, 2023

The relevant rlang PR has been merged, but not yet released.

@krlmlr
Copy link
Member

krlmlr commented May 19, 2023

Now in rlang 1.1.0.

@jennybc jennybc mentioned this issue Nov 2, 2023
Closed
hadley added a commit that referenced this issue Nov 7, 2023
@hadley
Don't show backtrace
0aa71b6 
Fixes #448. Closes #433. Closes #230.
@hadley hadley mentioned this issue Nov 7, 2023
Merged
jennybc added a commit that referenced this issue Nov 15, 2023
@hadley @jennybc
Don't show backtrace (#449)
ad02922 
* Don't show backtrace

Fixes #448. Closes #433. Closes #230.

* Re-document()

---------

Co-authored-by: Jenny Bryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show backtrace tidyverse/reprex
3 participants
@jennybc @krlmlr @lionel-