Update reprex-dos-and-donts.Rmd #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
iff is actually notation for "if and only if" https://en.wikipedia.org/wiki/If_and_only_if |
|
@mrchypark maybe we should spell that out, though! (I happen to know that because of proofs in philosophy.) Do you want to update the PR to make that explicit? |
|
@batpigandme omg.. my bad. anyway, It's good ideas to make that explicit. I'll update it. |
batpigandme
reviewed
Aug 22, 2018
vignettes/reprex-dos-and-donts.Rmd
Outdated
| @@ -80,7 +80,7 @@ The reprex code: | |||
|
|
|||
| * Should be easy for others to digest, so **they don't necessarily have to run it**. You are encouraged to include selected bits of output. :scream: | |||
|
|
|||
| * Should be easy for others to copy + paste + run, **if they so choose**. Don't let inclusion of output break executability. | |||
| * Should be easy for others to copy + paste + run, **iff(if and only if) they so choose**. Don't let inclusion of output break executability. | |||
There was a problem hiding this comment.
Add a space between iff and parens?
There was a problem hiding this comment.
Let's just replace "iff" with "if and only if".
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vignettes typo