Account for callr:r()'s handling of .Rprofile #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #340
Closes #284
This ended up playing out in 3 specific ways:
callr:r()
sees the reprex working directory as working directory, so that a project-specific.Rprofile
callr loads is guaranteed to be same as the.Rprofile
in working directory during reprex execution. I would regardreprex()
's behaviour w.r.t. this ever since callr's default changed to be ... undefined and/or wrong and/or surprising. With this behaviour,reprex()
's behaviour makes sense, by design..Rprofile
will now be indicated in the rendered reprex. I'm not 100% certain we should do this. In principle, it feels right, but there will be contexts where this may be annoying (e.g.reprex_rtf()
for slides). Then people will want to be able to turn it on/off. Is the hassle worth it?.Rprofile
now generates a user-facing alert. I'm almost 100% certain this is a good idea and won't face much resistance. Here's what that message looks like: