deactivate extension about yaml metadata block for pandoc 2.13+ #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #375 on reprex side fro now
As explained in #375 (comment), we need to make a fix for Pandoc's change in rmarkdown but I am not sure reprex would benefit from it directly because of the way the
reprex_document()
format is built. By not using thevariant=
argument inmd_document()
, any variant specific logic forgfm
insidermarkdown::md_document()
would not be applied.For a quick fix on reprex side, I have just added a switch to get Pandoc's extension deactivated for version 2.13 and above. This extension
yaml_metadata_block
has been activated by default in Pandoc now. This change in reprex does not require a new rmarkdown version.I did not add tests for now. I wanted to wait for your guidance about how you would like it to be in your test organization. And also because tests in reprex that runs Pandoc are currently already failing with recent Pandoc versions. However, you don't test several Pandoc versions for now in GHA, only 2.7.3 (the default for
r-lib/actions/setup-pandoc
).Happy to discuss it further and work on another way to fix it (with a fix in rmarkdown and a change in reprex)