collect config during initial creation

[reed-jones]

I noticed the config was initially being created as an array in ConfigFile, however in some places it was being used as a Collection instead (the Constructor for CollectionRemoteItemLoader). I previously fixed a very similar bug #423 and was tempted to remove the typehint again, but after a little digging I found what what happening.

in BuildCommand->includeEnvironmentConfig It actually overwrites the original array config with a new collection config. This fix just makes it a collection from the start, (and undoes my previous typehint removal)

[damiani]

Great idea, though I think it would be preferable to make the conversion directly in the ConfigFile constructor, rather than at the point where it's bound to the container as the config key. So, line 16 of ConfigFile could change to:

-   $this->config = array_merge($config, $helpers);
+   $this->config = collect(array_merge($config, $helpers));

... and then, update any places where can use collection access instead or array access (e.g. line 22 of the same file:)

-   $collections = Arr::get($this->config, 'collections');
+   $collections = $this->config->get('collections');

Finally, it would be good to audit any other uses of ConfigFile->config, and typehint them as Collection for consistency.

[reed-jones]

I wasn't sure what the most idiomatic way to convert this from an array => collection was with the default value. As far as I can tell the only place its ever called without passing a config is in the ViewRendererTest.php with it_does_not_register_view_hint_paths_if_not_specified_in_config I just didn't want to remove it incase I missed something.

[damiani]

@reed-jones This is great, I made a couple other adjustments. Thanks for this!