-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor container bootstrapping to use service providers #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9014553
to
bbaca24
Compare
13ddcdd
to
9dd2ae0
Compare
Just discovered another potential hiccup here—because |
damiani
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors Jigsaw's internal setup and service container bootstrapping to look a lot more like Laravel's Artisan CLI setup, including using our own custom Container class and introducing ServiceProvider classes. This starts laying the groundwork for some very interesting future possibilities, including:
Major plot points of this PR:
Container
class, extendingIlluminate\Container\Container
, and do environment/config bootstrapping and service provider setup there.jigsaw-core.php
file and perform most container setup in several new ServiceProvider classes, likeViewServiceProvider
andCollectionServiceProvider
.app()
helper to retrieve the container instance.app()->path()
andapp()->cachePath()
(more to come).Other changes worth mentioning—technically public-facing, but so minor or obscure that I don't think we need to worry about them breaking anything:
TightenCo\Jigsaw\Container
instead ofIlluminate\Container\Container
. Our container extends the Illuminate one though, so e.g. aninstanceof Container
check would still pass.TightenCo\Jigsaw\Events\FakeDispatcher
class was removed.See tightenco/jigsaw-v2#1.