Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - Add networking option on list command. #182

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] - Add networking option on list command. #182

wants to merge 4 commits into from

Conversation

danielebarbaro
Copy link
Contributor

No description provided.

@danielebarbaro
Copy link
Contributor Author

danielebarbaro commented Dec 9, 2020 •
edited
Loading

Hi, now list command have --networking option.
Screenshot 2020-12-09 at 10 03 27

Here an output example:

Screenshot 2020-12-09 at 10 02 39

--json option is done on #149 .

Do we need a network command to listtakeout network?

Screenshot 2020-12-09 at 10 18 34

@danielebarbaro danielebarbaro marked this pull request as ready for review December 9, 2020 09:08
@mattstauffer
Copy link
Member

Do we need a network command to list takeout network?

Would there be any particular value in that?

@mattstauffer
Copy link
Member

taking a look now!

mattstauffer
mattstauffer reviewed Jan 20, 2021
View reviewed changes
app/Shell/Docker.php
);
}

public function takeoutNetworkContainers(): Collection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename this takeoutContainersWithNetworking?

@mattstauffer
Copy link
Member

OK, looks good to me with the one suggestion fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstauffer mattstauffer mattstauffer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielebarbaro @mattstauffer