fix seekLeaderStore NPE #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <[email protected]>
|
/run-all-tests |
|
@iosmanthus please remove the necessary checks in PR description |
It is really hard to inject the error to trigger a double retry of seekLeaderStore. We can only use integration to cover this case. |
ti-srebot
approved these changes
Dec 9, 2021
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 9, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.1 in PR #371 |
zz-jason
pushed a commit
that referenced
this pull request
Dec 9, 2021
ankita25
pushed a commit
to ankita25/client-java
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Ankita Wagh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pull request fixes the NPE triggered by the double retry of
seekLeaderStore. These buggy lines would also introduce another issue likepeer id not matchbecause the meta of the region is not updated.What is changed and how it works?
Once we change detected a reachable store we need to update the peer information of the region and retry in the most outside code.
Check List
Tests
Code changes
Side effects
Related changes