Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to #421] add a python script to analyze slow log stats #527

Merged
merged 9 commits into from
Feb 22, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/license-checker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ header:
- 'dev/'
- 'docs/'
- 'metrics/'
- 'scripts/'
- 'LICENSE'
- 'Makefile'
- 'pom.xml'
Expand Down
8 changes: 3 additions & 5 deletions dev/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# TiSpark Dev Tools Guide
# TiKV Java Client Dev Tools

## Formatting

### Java Format
## Code Formatting

TiKV Java Client formats its code using [Google-Java-Format Maven Plugin](https://github.com/coveooss/fmt-maven-plugin) which follows Google's code styleguide. It is also checked on CI before build.

Expand All @@ -18,4 +16,4 @@ TiKV Java Client formats its code using [Google-Java-Format Maven Plugin](https:

```shell script
./dev/javafmt
```
```
File renamed without changes.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@
<execution>
<id>clone proto files</id>
<configuration>
<executable>${basedir}/scripts/proto.sh</executable>
<executable>${basedir}/dev/proto.sh</executable>
</configuration>
<phase>validate</phase>
<goals>
Expand Down
73 changes: 73 additions & 0 deletions scripts/rstats.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
#!/usr/bin/env python3
#!coding:utf-8

# Copyright 2022 TiKV Project Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

import re
import json
import argparse

def main():
pattern = r'.*SlowLog.*'
zz-jason marked this conversation as resolved.
Show resolved Hide resolved
slowstr = "SlowLog:"
grpc_pattern = "gRPC tikvpb.Tikv"
backoff_pattern = "backoff "

args = parse_args()
items = []
with open(args.slowlog, encoding = 'utf-8') as f:
for line in f.readlines():
matched = re.match(pattern, line, re.M|re.I)
if matched is not None:
log = json.loads(line[(line.index(slowstr) + len(slowstr)):])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there is a line containing corrupted JSON?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the script assumes that the slow log file is generated by tikv applications without manual modifications. If it's not a JSON, it means the file is mistakenly modified by someone, the script just not working since it breaks the assumption.

item = {
'req': log['func'],
'start': log['start'],
'tot_lat': int(log['duration'][:len(log['duration'])-2]),
zz-jason marked this conversation as resolved.
Show resolved Hide resolved
'tot_grpc': 0,
'tot_bo': 0,
}
items.append(item)
for span in log['spans']:
if grpc_pattern in span['name'] and span['duration'] != 'N/A':
item['tot_grpc'] += int(span['duration'][:len(span['duration'])-2])
elif backoff_pattern in span['name'] and span['duration'] != 'N/A':
item['tot_bo'] += int(span['duration'][:len(span['duration'])-2])

if args.order == "total":
items = sorted(items, key=lambda d: d['tot_lat'], reverse=True)
elif args.order == "grpc":
items = sorted(items, key=lambda d: d['tot_grpc'], reverse=True)
elif args.order == "backoff":
items = sorted(items, key=lambda d: d['tot_bo'], reverse=True)
else:
print("unsupported order option, use default value: total")
items = sorted(items, key=lambda d: d['tot_lat'], reverse=True)

fmtStr = "{:<12} {:<14} {:<14} {:<20} {:<20}"
print(fmtStr.format("Request", "Start", "Total Lat(ms)", "Total gRPC Lat(ms)", "Total Backoff Lat(ms)"))
for item in items:
print(fmtStr.format(item['req'], item['start'], item['tot_lat'], item['tot_grpc'], item['tot_bo']))

def parse_args():
parser = argparse.ArgumentParser(description="rstats: A TiKV Java Client Request Stats Analyzer")
parser.add_argument("--order", dest="order", default="total", help="order the output, default: total. accepted value: total, grpc, backoff")
zz-jason marked this conversation as resolved.
Show resolved Hide resolved
parser.add_argument("slowlog", help="slow log file")
return parser.parse_args()

if __name__ == '__main__':
main()