[close #619] Shutdown recycler when closing ChannelFactory to avoid resource leak

[Daemonxiao]

Signed-off-by: Daemonxiao [email protected]

What problem does this PR solve?

Issue Number: close #619

Because the recycler in ChannelFactory does not set any task when TLS is turned off, the process will get stuck on exit.

What is changed and how does it work?

When we don't use TLS, recycler should be null.

Code changes

• Has exported function/method change

Side effects

• NO side effects

Related changes

• Need to cherry-pick to the release branch

[codecov]

Codecov Report

Merging #618 (7742a6d) into master (d6a15c4) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master     #618      +/-   ##
============================================
- Coverage     34.72%   34.67%   -0.06%     
+ Complexity     1425     1423       -2     
============================================
  Files           278      278              
  Lines         17354    17356       +2     
  Branches       1972     1972              
============================================
- Hits           6027     6018       -9     
- Misses        10713    10735      +22     
+ Partials        614      603      -11     

Impacted Files	Coverage Δ
...main/java/org/tikv/common/util/ChannelFactory.java	62.64% <83.33%> (+0.43%)	⬆️
...va/org/tikv/common/region/StoreHealthyChecker.java	69.62% <0.00%> (-3.80%)	⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java	57.11% <0.00%> (-0.87%)	⬇️
...ty/handler/codec/http2/Http2ConnectionHandler.java	51.10% <0.00%> (-0.49%)	⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java	56.58% <0.00%> (-0.49%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a15c4...7742a6d. Read the comment docs.

[iosmanthus]

@Daemonxiao Could you create an issue with this pull request? The PR title checker will check if the PR is related to an issue.

[iosmanthus]

The tests for ChannelFactory might leak executors because some certWatcher or ChannelFactory are not closed automatically with the try-with-resource block. Could you fix it within this pull request? I think these two issues are related. Rest LGTM

[Daemonxiao]

/hold

[ti-srebot]

@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader.

[iosmanthus]

LGTM

[ti-srebot]

cherry pick to release-3.3 in PR #621