[close #635] constraint the getMember timeout by inject a backoffer #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
============================================
+ Coverage 34.68% 34.96% +0.28%
- Complexity 1420 1435 +15
============================================
Files 278 278
Lines 17358 17361 +3
Branches 1972 1974 +2
============================================
+ Hits 6020 6071 +51
+ Misses 10726 10675 -51
- Partials 612 615 +3
Continue to review full report at Codecov.
|
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
zhangyangyu
approved these changes
Jul 27, 2022
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jul 27, 2022
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.3 in PR #637 |
iosmanthus
added a commit
that referenced
this pull request
Jul 29, 2022
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: iosmanthus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus [email protected]
What problem does this PR solve?
Issue Number: close #635
Problem Description:
The
getMembersis not limited by abackoffer, which might cause the exception will not throw in time. For example, a user might set the timeout of a request to 400ms, but if the PD is disconnected, thegetMembersmight sleep more than 400ms since thebackofferit used is not passed from the upper code.What is changed and how does it work?
Inject a
backofferforgetMembersand check timeout before acquiring a channel from the pool.Check List for Tests
This PR has been tested by at least one of the following methods:
Related changes