[close #679] Let ColumnRef case insensitive #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shiyuhang <[email protected]>
shiyuhang0
changed the title
Codecov ReportBase: 35.01% // Head: 35.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #678 +/- ##
============================================
+ Coverage 35.01% 35.14% +0.13%
- Complexity 1446 1453 +7
============================================
Files 278 278
Lines 17382 17382
Branches 1975 1975
============================================
+ Hits 6086 6109 +23
+ Misses 10684 10662 -22
+ Partials 612 611 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
iosmanthus
approved these changes
Dec 13, 2022
zhangyangyu
approved these changes
Dec 15, 2022
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 20, 2022
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.3 in PR #690 |
zhangyangyu
pushed a commit
that referenced
this pull request
Dec 20, 2022
shiyuhang0
added a commit
to shiyuhang0/client-java
that referenced
this pull request
Dec 30, 2022
Signed-off-by: shiyuhang <[email protected]>
iosmanthus
pushed a commit
to iosmanthus/client-java
that referenced
this pull request
Dec 30, 2022
Signed-off-by: shiyuhang <[email protected]> Signed-off-by: iosmanthus <[email protected]>
shiyuhang0
pushed a commit
to shiyuhang0/client-java
that referenced
this pull request
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shiyuhang [email protected]
What problem does this PR solve?
Problem Description: close #679
ColumnRef should be case insensitive
What is changed and how does it work?
Change the hashcode method