Fix shellcheck CI job, fix/handle all shellcheck findings #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the shellcheck CircleCI job:
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
in https://app.circleci.com/pipelines/github/tilt-dev/tilt-extensions/1678/workflows/c1a75955-880d-408c-8188-cfe7651a9085/jobs/4065koalaman/shellcheck:stable
, which is not 7 years old.This PR additional fixes / handles all the previous not shown shellcheck findings, to get the noise down and the PR green -> CI becomes actionable feedback for new PRs.