Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify supported pattern matchers #57

Closed
embano1 opened this issue Jun 5, 2022 · 1 comment · Fixed by #60
Closed

Clarify supported pattern matchers #57

embano1 opened this issue Jun 5, 2022 · 1 comment · Fixed by #60

Comments

@embano1
Copy link
Collaborator

embano1 commented Jun 5, 2022 •
edited
Loading

From the README the following is not clear IMHO:

  • Which patterns are supported/implemented?
  • That this package follows EventBridge pattern matching, i.e. highlight as feature in README to reuse EB patterns?

Having a table which maps existing patterns, e.g. from EventBridge, to supported/unsupported in the README would be nice, e.g.:

Pattern Suppported Notes
exists Yes
shellstyle Yes* Only single wildcard * supported
number Yes* Number matching is weak

Thoughts?
@timbray
Copy link
Owner

timbray commented Jun 5, 2022

Agreed.

timbray added a commit that referenced this issue Jun 6, 2022
@timbray
chore: specification for Patterns
27baccf 
Closes: #57
Signed-off-by: Tim Bray <[email protected]>
@timbray timbray mentioned this issue Jun 6, 2022
Merged
@jsmorph jsmorph mentioned this issue Mar 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: specification for Patterns timbray/quamina
2 participants
@timbray @embano1