Fixed git_site_revision_date_localized #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason git_site_revision_date_localized was not properly processed, is twofold: - it was not processed if enable_creation_date was set to false - it was not replaced in the markdown page Both issues have been solved.
|
Good catch! Thanks for finding and fixing it! This bug was probably introduced in November 2021 (https://github.com/timvink/mkdocs-git-revision-date-localized-plugin/releases/tag/v0.10.1), when I added the new handle. I'll write an extra unit test to make ensure the behavior, and release it to pypi. |
|
Released in v0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason git_site_revision_date_localized was not properly processed, is twofold:
Both issues have been solved.